Fix compiler crash with -Ymagic-offset-header
#24124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tgodzik ! Could I request for a backport to 3.7.4? |
I think we'll have an RC2 @WojciechMazur ? |
|
Before merging, could you squash and rename the commits? Right now they are not quite informative. |
|
I will do it with the squash on github, it does use the PR description in those cases |
WojciechMazur
added
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24091
Since
span.startis only valid whenspan.exists, we just check that first before callingspan.startand otherwise fall back to the default code pathHaven't tested it, but from the stack trace it looks like it should fix the problem